Turbopack: include LightningCSS MediaIntervalSyntax feature #87533
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaRangeSyntax was added in a95f861. From my testing, the reason for adding MediaRangeSyntax still holds, and also applies to MediaIntervalSyntax, which I think is enough merit alone to add this. I stumbled across it separately though, via parcel-bundler/lightningcss#1114 This bug in LightningCSS causes range syntax to be improperly compiled when MediaIntervalSyntax isn't enabled. Since Next 16 updated the default browserlist to browsers new enough to not need MediaIntervalSyntax, this was disabled by default, surfacing that bug.
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaRangeSyntaxwas added in a95f861. From my testing, the reason for addingMediaRangeSyntaxstill holds, and also applies toMediaIntervalSyntax, which I think is enough merit alone to add this.I stumbled across it separately though, via parcel-bundler/lightningcss#1114
This bug in LightningCSS causes range syntax to be improperly compiled when
MediaIntervalSyntaxisn't enabled. Since Next 16 updated the default browserlist to browsers new enough to not needMediaIntervalSyntax, this was disabled by default, surfacing that bug.